Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sign_algo: fix inappropriate rustdoc comments. #152

Merged
merged 1 commit into from
Sep 5, 2023

Conversation

cpu
Copy link
Member

@cpu cpu commented Sep 5, 2023

Rustdoc doesn't generate rustdoc comments for expression fields. This commit replaces 4 occurrences of such comments in sign_algo.rs with normal comments to avoid breakage from more stringent checks for this condition in nightly rust.

Rustdoc doesn't generate rustdoc comments for expression fields. This
commit replaces 4 occurrences of such comments in `sign_algo.rs` with
normal comments to avoid breakage from more stringent checks for this
condition in nightly rust.
@cpu cpu self-assigned this Sep 5, 2023
@cpu cpu requested review from est31 and djc September 5, 2023 13:40
@cpu
Copy link
Member Author

cpu commented Sep 5, 2023

Exceptions that don't need my approval: CVE emergency fixes. Also: small 1-10 line grammar fixes. Latter can also be merged/approved by the person filing the PR if they are rustls maintainer.

I think this change is in the spirit of the exceptions that don't require est31's stamp so I'm going to merge this one. If you'd prefer I don't do that again in the future, please leave a comment so I can adjust my heuristic.

@cpu cpu merged commit 6af4302 into rustls:main Sep 5, 2023
10 checks passed
@cpu cpu deleted the cpu-fix-nightly-unused-doc-comments branch September 5, 2023 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants