Engine search, do not fall back to default_target #1136
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We used
default_target
just for historically reasons here (earlier it was even hardcoded to"classes"
).I'm not really sure that anyone really depends on this, as you can just set the
target
on a layer explicitly.It seems some tests are failing, which depends on this, i.e. they did not have
target
set on the layer (e.g.decision
layer) and assumed that thedefault_target
is set to the right target. There might be setups which have the same assumption, so they would break. I'm not really sure about the solution.Note that the current behavior, this fallback to
default_target
breaks my search, as I have some output layer which does not correspond to a target. So with this change, it just behaves as I expect, it just does not try to serialize with any vocab.