Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[patchmanager.spec] Specify icon paths more strictly #471

Merged
merged 1 commit into from
Nov 26, 2024
Merged

Conversation

Olf0
Copy link
Contributor

@Olf0 Olf0 commented Nov 25, 2024

No description provided.

@Olf0 Olf0 self-assigned this Nov 25, 2024
@Olf0
Copy link
Contributor Author

Olf0 commented Nov 25, 2024

The vast degree(s) of freedom for the icon paths is frightening me; well I know, technically it is only about deploying what has been copied from RPM's buildroot, but %{_datadir}/themes/sailfish-default/*/*/*/*.png … frightens me a bit.

A more rationale point is, that */*/*/*.png is really hard for a reader to retrace which files are meant to become deployed here.

BTW, I restricted my self to specify %{_datadir}/themes/sailfish-default/*/z*/icons*/*.png while I was considering %{_datadir}/themes/sailfish-default/{silica,meegotouch}/z?.?*/icons*/*.png. If a reviewer prefers the latter, I will happily use that; I was just afraid this would be regarded as "olf is nitpicking again" (and I never used brace expansion in a spec file's file list before).

@nephros
Copy link
Contributor

nephros commented Nov 26, 2024

LGTM.

BTW, I restricted my self to specify %{_datadir}/themes/sailfish-default/*/z*/icons*/*.png while I was considering %{_datadir}/themes/sailfish-default/{silica,meegotouch}/z?.?*/icons*/*.png. If a reviewer prefers the latter, I will happily use that; I was just afraid this would be regarded as "olf is nitpicking again" (and I never used brace expansion in a spec file's file list before).

I'm not sure the path expansion with curly braces would work with RPM.

I'm fine with the former variant.

@Olf0 Olf0 merged commit ee4254c into master Nov 26, 2024
1 check passed
@Olf0 Olf0 deleted the Olf0-patch-1 branch November 26, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants