Improve 64bit mangling, support file creation #476
+46
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Olf0
reviewed
Nov 27, 2024
There was a problem hiding this comment.
This PR in its final form looks absolutely reasonable to me, but (as often stated) I am not a C++ coder.
The corresponding analysis and code development was actually fun to read after spending an exhausting working day mostly in teleconferences:
the analysis in issue #468, especially #468 (comment)
Still I would prefer @b100dian to review this, especially as he was heavily involved in creating the 32-/64-bit Patch-mangling in the first place, IIRC.
If @b100dian has no time for a review, I sure will approve this, just ping me (either @b100dian or @nephros).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #468
For details, see some of the comments in the file, and the analysis in issue #468, especially
#468 (comment)