Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support alternate audio vizualizers #186

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mbklein
Copy link
Member

@mbklein mbklein commented Mar 14, 2024

I did this so that I could plug in audioMotion-analyzer and make use of its full range of options. And it has a lot of options. Sample implementation of an alternative visualizer can be seen here, and how it integrates with the Viewer here. It's a bit clunky with all the refs and casting, but I couldn't find a way around it.

Here it is in action, with the same 15-second audio clip (redacted) and three different configurations:

audioviz1.mp4
audioviz2.mp4
audioviz3.mp4

The AudioMotion implementation could also just be pulled directly into Clover, but it would add another dependency you might not want.

@mbklein mbklein requested a review from mathewjordan March 14, 2024 00:01
@mbklein mbklein force-pushed the alternate-audio-visualizer branch from 4b7f77f to d8acb2c Compare March 14, 2024 00:16
@mathewjordan
Copy link
Member

This is a pretty cool idea. I think we can figure it out but just need to document it.

Would be to cool to see this idea with https://wavesurfer.xyz/

Now that you have spent some time in the code, how do you think we can cleanup the Viewer Context and the config for the better? It seems like we have a highly customizable Viewer here, which is great, but I'm just trying to figure out the best way to let it be malleable without it becoming unwieldy.

@mbklein
Copy link
Member Author

mbklein commented Mar 14, 2024

wavesurfer looks fun, and it already has a react hook. It's different from the other visualizers in that it represents the track as a timeline from left to right instead of a changing point-in-time graph – not a problem; just a different approach. I wonder how it would deal with streaming audio not loading all at once, especially for long streams.

I wonder if the context and config could be pluggable? Let different pieces (like the information panel) register themselves and be responsible for their own config/event logic? I don't think it would be that difficult to delegate.

@mbklein mbklein force-pushed the alternate-audio-visualizer branch from d8acb2c to d08ec9d Compare March 29, 2024 14:17
Copy link
Member

@mathewjordan mathewjordan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @mbklein, I put some eyes on this again. I think we just need to add some docs for these options to push it through -- unless we wanted to tidy up configuration as noted above first.

@mbklein mbklein force-pushed the alternate-audio-visualizer branch from d08ec9d to 5480252 Compare June 5, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants