Set default labels as index + 1 for canvas figures. #232
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
This sets the default label for canvas figures (thumbnails) in the media component in cases where the Canvas does not have a label. The label will be the
(index + 1).toString()
to accommodate all languages. This same label will be thealt
of the rendered thumbnail as well. Filtering will also work in this cases, ex: "2" as the input value will be show the "2", "12", "21", "22", etc... thumbnails.How to review?
Review with this fixture
https://samvera-labs.github.io/clover-iiif/docs/viewer/demo?iiif-content=https%3A%2F%2Fmarkpbaggett.github.io%2Fstatic_iiif%2Fmanifests%2Ftests%2Fservice_maps_0103.json