Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detect dir of rtl or ltr based on BCP47 language codes #239

Merged
merged 1 commit into from
Dec 12, 2024
Merged

Detect dir of rtl or ltr based on BCP47 language codes #239

merged 1 commit into from
Dec 12, 2024
+75 −3

Conversation

kdid
Copy link
Contributor

@kdid kdid commented Dec 12, 2024 •
edited
Loading

  • Determine direction of language from the BCP47 code.

@kdid kdid force-pushed the 238-determine-language-dir branch from d2bca2e to 51c3ac7 Compare December 12, 2024 19:45
@kdid kdid marked this pull request as ready for review December 12, 2024 19:55
@kdid kdid requested a review from mathewjordan December 12, 2024 19:55
@kdid kdid self-assigned this Dec 12, 2024
mathewjordan
mathewjordan approved these changes Dec 12, 2024
View reviewed changes
Copy link
Member

@mathewjordan mathewjordan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎸

@mathewjordan mathewjordan merged commit 7f8f210 into main Dec 12, 2024
1 check passed
@mathewjordan mathewjordan deleted the 238-determine-language-dir branch December 12, 2024 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mathewjordan mathewjordan mathewjordan approved these changes

Assignees

@kdid kdid

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kdid @mathewjordan