Bump Ruff to 0.8.0 #949
Merged
Bump Ruff to 0.8.0 #949
+11
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henryiii
approved these changes
Nov 22, 2024
|
Perfect, thanks! I’ve been using RUF022 and 23 in a few places already, great to see them in stable! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! I just released Ruff 0.8.0. This release removes a few rules that had been deprecated for a few releases, so Ruff 0.8.0 would have started emitting warnings when linting
scikit-build-coredue to the fact that you have some of these now-removed rules explicitly ignored in your Ruff config.This PR gets rid of the removed rules from your Ruff config. There's also some additional changes made here due to some rule stabilisations in this release -- let me know if these are unwelcome, and I can add them to the
tool.ruff.lint.ignorelist:unsorted-dunder-all(RUF022) andunsorted-dunder-slots(RUF023)src/scikit_build_core/builder/get_requires.pyhas been changed slightly due to the stabilisation ofparenthesize-chained-operators(RUF021)