snet: fix UDP port selection on Windows #4656
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
jiceatscion
reviewed
Nov 25, 2024
There was a problem hiding this comment.
It doesn't seem necessary to duplicate the code. If the only difference is the value of the error code, then please make a windows and unix versions of just that constant (of a function that abstracts iit to "thisIsTheErrorYourLookingFor()".
Reviewed 1 of 4 files at r1, all commit messages.
Reviewable status: 1 of 4 files reviewed, all discussions resolved
lschulz
commented
Dec 7, 2024
There was a problem hiding this comment.
I created a function errorIsAddrUnavailable() to test if the error code indicates an unavailable port as there are at least two error codes indicating this kind of situation in Windows.
Reviewable status: 0 of 6 files reviewed, all discussions resolved (waiting on @jiceatscion)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SNET is checking the wrong error code when probing for available UDP ports.
Windows socket error codes are completely different from Linux, thus different OSes must be distinguished.