run SCION as services on Windows #4657
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
jiceatscion
reviewed
Nov 25, 2024
There was a problem hiding this comment.
There seems to be a lot of identical between the windows and unix implementations. For example the unix version of the Application data structure is a subset of the Windows one. Would mind trying to move more of the common code to launcher.go?
Reviewed 1 of 4 files at r1, all commit messages.
Reviewable status: 1 of 4 files reviewed, all discussions resolved
lschulz
commented
Dec 8, 2024
There was a problem hiding this comment.
I moved more common code to launcher.go.
Reviewable status: 0 of 9 files reviewed, all discussions resolved (waiting on @jiceatscion)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there seems to be no way to cleanly terminate a SCION service on Windows. Typing Ctrl-C terminates the program without running cleanup code.
This PR allows running SCION as services on Windows. Applications detect automatically whether they were started as a service or as console applications and will react to control request appropriately. If running as console application Ctrl-C is handled correctly.