Drop Python 3.9 support #159
Conversation
|
@jl-wynen Any idea why the serialization tests are failing here? They were disabled for Python 3.9, but are broken now for 3.10. |
I fixed it, but I was wondering if this was expected. |
There was a problem hiding this comment.
Do you want to keep the pytest skip mark on the tests? I think it can be removed.
| @@ -98,55 +98,55 @@ def node_sort_key(node: dict[str, Any]) -> str: | |||
| 'id': '1', | |||
| 'label': 'to_string', | |||
| 'kind': 'function', | |||
| 'function': 'json_test.to_string', | |||
| 'function': 'tests.serialize.json_test.to_string', | |||
There was a problem hiding this comment.
No, I didn't expect this. It is caused by --import-mode=importlib in pytest that was added in this PR.
There was a problem hiding this comment.
... but is this change fine?
There was a problem hiding this comment.
I'd say so. This is a particular detail of how pytest works. In a normal Python process, it should always use the full module path.
No description provided.