fix: remove wrapping Optional if python version < 3.11 #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+307
to
+310
| if sys.version_info[1] < 11: | ||
| for name, param in inspect.signature(func).parameters.items(): | ||
| if param.default is None: | ||
| hints[name] = get_args(hints[name])[0] |
There was a problem hiding this comment.
What happens if the function signature is f(a: int | None = None)? We don't want to remove the optional in that case!
There was a problem hiding this comment.
Aha, I thought an additional optional was added as a wrapper also in that case, but I guess it isn't.
There was a problem hiding this comment.
I don't know if there's a good way to fix this. Maybe better in that case to just do nothing and wait for later python versions like was suggested in the issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #182