Add mode argument to visualize for more compact data or task graph display
#187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nvaytet
reviewed
Oct 30, 2024
| ) | ||
| cluster_connected.append(arg.name) | ||
| else: | ||
| dot.edge(arg.name, ret_name) | ||
| # else: Do not draw dummy providers created by Pipeline when setting instances | ||
|
|
There was a problem hiding this comment.
I don't think the curved arrows are always better. Comparing the new to old figure, while there are less boxes and duplication in the new figure, I find it harder to follow the arrows.
New:
Old:
There was a problem hiding this comment.
Hmm, why are they curved now?
There was a problem hiding this comment.
Avoided some, see update.
nvaytet
approved these changes
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is an before and after for ESSsans'
IofQ[SampleRun].Before:
After:
Fixes #82.