Use str repr for param table html repr when __name__
does not exist
#45
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses the string representation for the html_repr column names in the case where
.__name__
is not defined.This is the case for
python<3.10
.One slightly annoying thing is that when you have a parameter defined as
Filename[Sample]
, in py310 the column header will beFilename
, while in py39 it becomesFilename[Sample]
.I could not use the string repr (with module name stripped) for all cases, because when you have a type defined simply as
Filename = NewType('Filename', str)
, then the column name becomes something likenew_type at 0x7f48681074c0>
. In this case it is better to use the.__name__
.So we use the name when we can, and the string repr when
.__name__
is not available.Fixes #38