Better handling of typing.Optional
#50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jl-wynen
reviewed
Sep 1, 2023
| def require_union(x: Union[int, float]) -> str: | ||
| return f'{x}' | ||
|
|
||
| pipeline = sl.Pipeline([require_union]) |
There was a problem hiding this comment.
Can you add a provider for int and/or float so this actually tests something?
There was a problem hiding this comment.
Good point, see update!
There was a problem hiding this comment.
Please add tests where there is an optional and a required dependency on some value. And check that it works for any order or providers and whether the value can be provided or not.
There was a problem hiding this comment.
I added one test, not entirely sure what the other cases you are asking for are.
jl-wynen
approved these changes
Sep 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #40.
Should we add top-level docs for this?