Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT/DEV: pin sphinx in environment.yml, bump jupyterlite-sphinx #21481

Merged
merged 3 commits into from
Aug 31, 2024

Conversation

lucascolley
Copy link
Member

Reference issue

n/a

What does this implement/fix?

gh-21324 for environment.yml too. @agriyakhetarpal how are we looking for removing these pins after jupyterlite/jupyterlite-sphinx#201 ?

Additional information

@gertingold bumped into this at the EuroSciPy 2024 sprint!

scipygh-21324 for `environment.yml` too

[skip cirrus]
@github-actions github-actions bot added the DX Everything related to making the experience of working on SciPy more pleasant label Aug 30, 2024
@lucascolley lucascolley added this to the 1.15.0 milestone Aug 30, 2024
@agriyakhetarpal
Copy link
Contributor

agriyakhetarpal commented Aug 30, 2024

Hi @lucascolley, thanks for the ping! This should be resolved by now, shouldn't it? jupyterlite/jupyterlite-sphinx#201 was released in https://github.com/jupyterlite/jupyterlite-sphinx/releases/tag/v0.16.5, and https://anaconda.org/conda-forge/jupyterlite-sphinx/files has version 0.16.5 available, too (conda-forge/jupyterlite-sphinx-feedstock#34). Please let me know if if you think something was/is misconfigured!

@lucascolley
Copy link
Member Author

lucascolley commented Aug 30, 2024

would you like to open a PR to remove the pins, and see if CI agrees? I can't remember the exact message we saw locally, but it was some deprecation warning coming from Sphinx.

@agriyakhetarpal
Copy link
Contributor

Sure, let me do that. There is a chance it might have come from MyST-NB, though – which had the same issue until yesterday: executablebooks/MyST-NB#620

@lucascolley
Copy link
Member Author

which had the same issue until yesterday

Right, that might be it!

@lucascolley lucascolley removed this from the 1.15.0 milestone Aug 30, 2024
@lucascolley lucascolley marked this pull request as draft August 30, 2024 14:45
@gertingold
Copy link
Contributor

The error I was encountering today with Sphinx 8.0.2 was

Exception occurred:
  File "/home/gert/.conda/envs/scipy-dev-test/lib/python3.12/site-packages/sphinx/util/_pathlib.py", line 96, in __getattr__
    warnings.warn(_MSG, RemovedInSphinx90Warning, stacklevel=2)
sphinx.deprecation.RemovedInSphinx90Warning: Sphinx 9 will drop support for representing paths as strings. Use "pathlib.Path" or "os.fspath" instead.

@agriyakhetarpal
Copy link
Contributor

That's iteresting, Sphinx seems to report a warning from Sphinx itself...

@lucascolley lucascolley changed the title DEV: pin sphinx in environment.yml MAINT/DEV: pin sphinx in environment.yml Aug 31, 2024
@lucascolley lucascolley changed the title MAINT/DEV: pin sphinx in environment.yml MAINT/DEV: pin sphinx in environment.yml, bump jupyterlite-sphinx Aug 31, 2024
@lucascolley lucascolley added the maintenance Items related to regular maintenance tasks label Aug 31, 2024
@lucascolley lucascolley added this to the 1.15.0 milestone Aug 31, 2024
@lucascolley lucascolley marked this pull request as ready for review August 31, 2024 11:17
@lucascolley
Copy link
Member Author

thanks @agriyakhetarpal ! I'll merge this to fix the dev setup right now, and hopefully we can remove the pin in gh-21482 soon.

@lucascolley lucascolley merged commit 7d56ab6 into scipy:main Aug 31, 2024
38 checks passed
@lucascolley lucascolley deleted the pin-sphinx branch August 31, 2024 12:42
@agriyakhetarpal
Copy link
Contributor

Yes, sounds great, @lucascolley! I hope your talk at EuroSciPy went well and that you have a great time at the NF summit!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DX Everything related to making the experience of working on SciPy more pleasant maintenance Items related to regular maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants