Fix: avoid matching capture pattern name ( Fixes #291) #301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfraudeau
changed the title
|
Thank you @jfraudeau ! Could you please add a test for this as well? |
|
Test added @ocramz thanks for your time |
ocramz
requested changes
Oct 28, 2023
ocramz
reviewed
Dec 17, 2023
There was a problem hiding this comment.
Sorry for taking so long @jfraudeau , would you mind adding a changelog entry for this as well? Thank you!
|
Oh and please fix the conflict in the test files. Thanks again! |
|
All done, I hope the changelog entry is clear enough |
ocramz
approved these changes
Dec 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As stated in the issue #291, GET /test/:capture would match a capture defined as
get "/test/:capture" _handlerwith thecaptureabsent from params.With this fix the param would be set to literally
":capture