Handle exceptions from scotty as ScottyException #345
Merged
+98
−60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ocramz
reviewed
Oct 21, 2023
fumieval
force-pushed
the
scotty-exception
branch
2 times, most recently
from
f78880d
to
ed8f3d0
Compare
ocramz
reviewed
Oct 22, 2023
fumieval
force-pushed
the
scotty-exception
branch
from
ed8f3d0
to
8f6162f
Compare
|
@ocramz Do you have any remaining concerns? |
ocramz
requested changes
Nov 3, 2023
fumieval
force-pushed
the
scotty-exception
branch
2 times, most recently
from
8f6162f
to
6dd48a7
Compare
|
I'm going to deprecate |
|
@ocramz ping |
|
Hi @fumieval! I haven't forgotten about this, it's just that I'm on a
family holiday until the end of the month. Will look at it then! Best, Marco
…On Tue, 21 Nov 2023 at 15:49, Fumiaki Kinoshita ***@***.***> wrote:
@ocramz <https://github.com/ocramz> ping
—
Reply to this email directly, view it on GitHub
<#345 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABNBDKGHTZC6A7TS5WTF5CLYFRFGVAVCNFSM6AAAAAA6IR7HZ2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMRQGMZTENJWGU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
@ocramz I see, great! Have a wonderful vacation |
ocramz
approved these changes
Nov 30, 2023
|
@fumieval could you add a Changelog entry about this as well please? |
fumieval
force-pushed
the
scotty-exception
branch
from
ff36c73
to
8107e16
Compare
|
@ocramz Sure, I updated the changelog |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change replaces the use of
StatusErrorbyScottyException. The idea is to avoid returning a error response in an arbitrary format and make it more reasonable to catch them, because catchingStatusErrordoesn't make much senseFor the sake of compatibility, I kept the StatusError type but I think it should eventually be deprecated.
closes #338