Add doctest #354
Merged
Add doctest #354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ocramz
changed the title
|
WIP example docstrings using curl should be ported to use hspec-wai |
|
I've ported a few docstrings to doctest, now we can be sure the examples stay in sync with the code :) There's a bit of code duplication but doctest doesn't seem to follow module imports and I'd rather not import 'http-client' into the main scotty library. |
fumieval
approved these changes
Dec 4, 2023
|
@fumieval have you used doctest before? Do you have an idea for fixing the
error in the $setup block that appeared in CI?
…On Mon, 4 Dec 2023 at 02:43, Fumiaki Kinoshita ***@***.***> wrote:
***@***.**** approved this pull request.
—
Reply to this email directly, view it on GitHub
<#354 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABNBDKBG6KYANKIQOPMA7MTYHUTEZAVCNFSM6AAAAABACLACS6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTONRRGQ3TIMJUGM>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Hmm I'm not quite sure what is going on :/ |
|
@fumieval ahh figured this out! it's a GHCi bug, unrelated to doctest. GHCi only recently started supporting multiline imports : https://github.com/scotty-web/scotty/actions/runs/7075697407/job/19258105080?pr=354#step:7:95, related GHC ticket: https://gitlab.haskell.org/ghc/ghc/-/issues/20473 |
|
I'll merge this for now, we can revisit later if needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #353