Fixed Cookie example from Cookie module #391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @ocramz, I thought about that approach as well. html $ mconcat [ "<html><body>"
, TL.fromStrict hits'
, "</body></html>"
]Let me know which approach you prefer. |
|
Thank you @tusharad ! Your implementation makes a lot of sense. Could you add an entry to the Changelog as well, under Next, please? |
|
Hello @ocramz, I've just added an entry to the changelog as requested. Do let me know if you need any adjustments. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Description:
The original example in the Web.Scotty.Cookie module encountered two primary issues that hindered its functionality:
getfunction, was not included in the import list from theWeb.Scottymodule, leading to a missing function error.getCookiefunction was expected to return aLazy Texttype, but instead, it returned a strict Text type. This discrepancy caused a type mismatch with theTL.decimalfunction, which requires a Lazy Text type.Solution Implemented:
getfunction has now been added to the import list within theWeb.Scotty.Cookiemodule.TL.fromStrictfunction. This conversion aligns with the expected input type for the html function, thereby resolving the type mismatch issue.@ocramz