Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove trace from debug log #919

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

Thegaram
Copy link

1. Purpose or design rationale of this PR

Debug logs are too large to be inspected. Remove trace from debug logs.

2. PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • fix: A bug fix

3. Deployment tag versioning

Has the version in params/version.go been updated?

  • This PR doesn't involve a new deployment, git tag, docker image tag, and it doesn't affect traces
  • Yes

4. Breaking change label

Does this PR have the breaking-change label?

  • This PR is not a breaking change
  • Yes

@Thegaram Thegaram requested a review from georgehao July 24, 2024 00:47
georgehao
georgehao previously approved these changes Jul 24, 2024
Comment on lines 59 to 62
log::warn!(
"failed to parse trace in parse_json_to_rust_trace, error: {:?}, trace_json_cstr: {:?}",
"failed to parse trace in parse_json_to_rust_trace, error: {:?}",
e,
trace_json_cstr,
);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can log::warn the error, and log::debug the trace_json_cstr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants