[wip] add pcs trait #3
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
chaosma
commented
Nov 28, 2024
chaosma
commented
- add pcs trait from ceno
- Adapt whir pcs code according to pcs trait
chaosma
force-pushed
the
pcs_trait
branch
2 times, most recently
from
4171495
to
1aa366b
Compare
|
I suggest keeping the modification as separated as possible from the existing code, because the upstream is still under active development, and we may want to periodically merge in their optimizations and bug fixes. Modifying the existing files directly may introduce a lot of changes due to cargo fmt, and more and more (unnecessary) merge conflicts. |
|
I picked the most important changes from this PR to a new branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.