-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lots of little updates and a few features. #47
base: master
Are you sure you want to change the base?
Conversation
…only if not absolute through using the recomended project.projectDir and project.rootDir references in the variable definitions.
…e compiled within a directory, with the default being all '**/*.xsd'.
…em property that causes the plugin to not work as expected under JSE8.
…o calling XJC in order to prevent a FileNotFoundException from being thrown.
…e project properties.
…ypos, and other misc. that hadn't been previously commited.
…buildDir} to allow more flexibility.
…0 since it was being confused with the method of the same name.
…hat XJC Plugins can be used.
… project execution.
…anging the default to the multi-process safe XJC2Task.
I like these changes :) Thanks! |
Hi, wondering what's the plan to merge this pull request and release a new version of the plugin? @wdschei do you've a sample |
I don't know if he is going to officially release a new version of this, but if you take a look at this you can use the forked version we published. |
Thanks @wdschei. Did you publish to jcenter or maven central? And do you any examples for me to get started? I've an existing Maven config that uses a plugin to put annotation on generated classes.
|
@abhijitsarkar We haven't publish to jcenter or maven central yet, in hopes that this pull request would be accepted and then it would be published as merely a new release. Since it wasn't in a timely manner, we did publish to the public Rackspace repository. My little hello-world'ish project is located at: The project I work on and what prompted this pull request can be found here: Both are good examples, it just depends on how well versed in Gradle as to which one would be better for you. That said, it is on our backlog to publish our changes to a more standard repository at some point if this pull request is not accepted by then. |
@wdschei thanks again. I'll look. I think I know gradle enough to understand build scripts, however, as you can see in the code snippet above, I'm using a JAXB plugin, so I'll have to find a way to feed that to the gradle plugin. |
EDIT: The Repose master branch has been migrated to Gradle and the links have been updated. @abhijitsarkar I forgot to mention that the Repose master branch is still on Maven for a couple more weeks, but the branch below has been migrated to Gradle: Specifically, the Notice the |
I'm looking here for indication of what you said "support for setting the classpath argument of the XJC Ant task" and don't see any. I'll now start digging through source code, but if you may provide a helpful pointer, I'll appreciate that. |
It is not in that documentation yet, we just added the same capabilities to the XJC module as were already present for the JAXB module. |
Putting in another plug to get this PR accepted. I'm new to Gradle from the maven world, and would like to be able to use this plugin. Tracking down the error in the JaxbPlugin (the improperly calculated xjc.conventionMapping.generatedFilesDirectory) was highly instructional :-) Thx. |
+1 I need support for |
EDIT: Since this PR was not accepted/merged, the Repose team did publish this to the Gradle Plugins repository: @esetnik As mentioned previously, it is on my team's backlog to get this published to a more common repository. In the mean time though, you can always use the version we have published to our public repository:
Example projects are linked above too. |
I'm still not able to run xjc task with an XSD that contains external references with: |
@Nafiux Are you using the plugin from this repository or the one from the fork referenced in this PR? |
I would have normally split this into multiple PR's, but they were to interleaved and I wanted to get this back out.
project.dir
to instead use the standard Gradle naming.**/*.xjb
accessExternalSchema
system property in JSE 8.classpath
argument of the XJC Ant task so that XJC plugins can be used.There are two unit tests that are failing using Gradle v1.12 and I can't get the integration tests to run at all.
I have also started trying to compile this under Gradle v2.10 and that is going fairly well. We forked it over here, https://github.com/rackerlabs/gradle-jaxb-plugin, and just brought in the source from the
gradle-xsd-wsdl-slurping
library. Same thing over there with not being able to run the integration tests~~, but there is only one test failing over there out of all the combined unit tests~~. It is also a different test than what is failing under Gradle v1.12. So I don't know.Thanks for the great start on this, updating it was definitely better than starting from scratch.
EDIT: The last failing unit test was fixed with wdschei/gradle-jaxb-plugin@227e2d5.
EDIT: There is also a simple parallel build test that uses the the Rackspace published artifacts here: https://github.com/wdschei/gradle-jaxb-plugin-test