Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text to id changes #1338

Merged
merged 4 commits into from
Mar 28, 2023
Merged

Text to id changes #1338

merged 4 commits into from
Mar 28, 2023

Conversation

pvk-developer
Copy link
Member

@pvk-developer pvk-developer commented Mar 27, 2023

Resolves #1324
Resolves #1325

@codecov-commenter
Copy link

codecov-commenter commented Mar 27, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.13 🎉

Comparison is base (7070d64) 95.95% compared to head (7781b72) 96.08%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1338      +/-   ##
==========================================
+ Coverage   95.95%   96.08%   +0.13%     
==========================================
  Files          47       47              
  Lines        3704     3680      -24     
==========================================
- Hits         3554     3536      -18     
+ Misses        150      144       -6     
Impacted Files Coverage Δ
sdv/data_processing/data_processor.py 98.57% <100.00%> (+1.48%) ⬆️
sdv/datasets/demo.py 100.00% <100.00%> (ø)
sdv/metadata/metadata_upgrader.py 100.00% <100.00%> (ø)
sdv/metadata/single_table.py 98.83% <100.00%> (+<0.01%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pvk-developer pvk-developer marked this pull request as ready for review March 27, 2023 23:30
@pvk-developer pvk-developer requested a review from a team as a code owner March 27, 2023 23:30
@pvk-developer pvk-developer requested review from fealho, amontanez24 and frances-h and removed request for a team and fealho March 27, 2023 23:30
@pvk-developer pvk-developer merged commit 86fbfe7 into master Mar 28, 2023
@pvk-developer pvk-developer deleted the text-to-id-changes branch March 28, 2023 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change auto_assign_transformers to handle id types Change 'text' sdtype to 'id'
3 participants