Windows numpy hang #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The numpy library has a bug when importing on Windows with stdin already open, which causes numpy to hang, because it also tries to read from stdin internally. See: numpy/numpy#24290 To avoid this, a proper fix will be to add a feature to Appose to pass some kind of init script that is run early, before the Appose pipes get established. Then it would be as simple as passing a single line `import numpy` as the init script in code that needs to avoid this bug. But because SAMJ currently ships its own zipped copy of appose-python, we add the following block of code to appose-python's python_worker.py: # HACK: Avoid numpy hang on Windows systems when stdin is open. # numpy/numpy#24290 if sys.platform.startswith("win"): try: import numpy except Exception as e: print(f"[WARNING] Failed to import numpy eagerly: {e}", file=sys.stderr) (You can't see the patch directly here since it's inside the zip file.)
It is already false by default in the interface.
|
@carlosuc3m The CI check fails because the main branch is currently broken. I already uploaded this fix (which branches from the previously uploaded build, not the current tip of main) to the SAMJ update site. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a hang on Windows where
import numpyrun too late, after Appose already starts reading from stdin, never returns. The relevant bug is numpy/numpy#24290. To work around this, we can simply do a try/except onimport numpyat the very beginning of thepython_worker.py, in the bundled appose-python. The proper fix later will be for Appose to support passing an init script so that users of the library can simply pass a script with onlyimport numpyat environment construction time. But for now, this hack works to make SAMJ work on Windows.