Support for SystemJS in MadKudu integration #765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@varadarajan-tw can I have your review on this please? 🙏 |
There was a problem hiding this comment.
LGTM! Could you update the patch version in package.json here?
varadarajan-tw
approved these changes
Jul 27, 2023
GhassenRjab
force-pushed
the
support-systemjs
branch
from
899a761 to
c127251
Compare
|
@varadarajan-tw I updated the version. Do I need to rebase my branch? |
|
Hey, Yes. Please rebase the branch! |
GhassenRjab
force-pushed
the
support-systemjs
branch
from
c127251 to
86698d7
Compare
|
I just rebased the branch is up to date! |
|
Hey @GhassenRjab, this change has been deployed to all the customers. |
AnkitSegment
added a commit
that referenced
this pull request
Aug 4, 2023
* [Walkme] Add option to choose a custom bucket (#759) * Add option to choose a custom bucket --------- Co-authored-by: Varadarajan V <[email protected]> Co-authored-by: Varadarajan V <[email protected]> * bump walkme integration version to 1.2.0 (#768) * fixes typo and related test (#771) * fixes typo and related test some test were returning false positive, update the way to check on them * bump package version to 1.2.1 --------- Co-authored-by: Varadarajan V <[email protected]> * Support for SystemJS in MadKudu integration (#765) * UMD need window.require * Update version * STRATCONN-2841 added msgid as event id in propertyMap Added this property to test on stage branch * updating version * resolve conflit --------- Co-authored-by: paco-walkme <[email protected]> Co-authored-by: Varadarajan V <[email protected]> Co-authored-by: Varadarajan V <[email protected]> Co-authored-by: Ghassen Rjab <[email protected]>
AnkitSegment
added a commit
that referenced
this pull request
Aug 4, 2023
* [Walkme] Add option to choose a custom bucket (#759) * Add option to choose a custom bucket --------- Co-authored-by: Varadarajan V <[email protected]> Co-authored-by: Varadarajan V <[email protected]> * bump walkme integration version to 1.2.0 (#768) * fixes typo and related test (#771) * fixes typo and related test some test were returning false positive, update the way to check on them * bump package version to 1.2.1 --------- Co-authored-by: Varadarajan V <[email protected]> * Support for SystemJS in MadKudu integration (#765) * UMD need window.require * Update version * STRATCONN-2841 added msgid as event id in propertyMap Added this property to test on stage branch * updating version * resolve conflit * added console to track --------- Co-authored-by: paco-walkme <[email protected]> Co-authored-by: Varadarajan V <[email protected]> Co-authored-by: Varadarajan V <[email protected]> Co-authored-by: Ghassen Rjab <[email protected]>
AnkitSegment
added a commit
that referenced
this pull request
Aug 4, 2023
* [Walkme] Add option to choose a custom bucket (#759) * Add option to choose a custom bucket --------- Co-authored-by: Varadarajan V <[email protected]> Co-authored-by: Varadarajan V <[email protected]> * bump walkme integration version to 1.2.0 (#768) * fixes typo and related test (#771) * fixes typo and related test some test were returning false positive, update the way to check on them * bump package version to 1.2.1 --------- Co-authored-by: Varadarajan V <[email protected]> * Support for SystemJS in MadKudu integration (#765) * UMD need window.require * Update version * msg id and version updated * fixed walkme test case file --------- Co-authored-by: paco-walkme <[email protected]> Co-authored-by: Varadarajan V <[email protected]> Co-authored-by: Varadarajan V <[email protected]> Co-authored-by: Ghassen Rjab <[email protected]>
AnkitSegment
added a commit
that referenced
this pull request
Aug 4, 2023
* [Walkme] Add option to choose a custom bucket (#759) * Add option to choose a custom bucket --------- Co-authored-by: Varadarajan V <[email protected]> Co-authored-by: Varadarajan V <[email protected]> * bump walkme integration version to 1.2.0 (#768) * fixes typo and related test (#771) * fixes typo and related test some test were returning false positive, update the way to check on them * bump package version to 1.2.1 --------- Co-authored-by: Varadarajan V <[email protected]> * Support for SystemJS in MadKudu integration (#765) * UMD need window.require * Update version * msg id and version updated * fixed walkme test case file * msg id added in productPropertyMap --------- Co-authored-by: paco-walkme <[email protected]> Co-authored-by: Varadarajan V <[email protected]> Co-authored-by: Varadarajan V <[email protected]> Co-authored-by: Ghassen Rjab <[email protected]>
AnkitSegment
added a commit
that referenced
this pull request
Aug 7, 2023
* [Walkme] Add option to choose a custom bucket (#759) * Add option to choose a custom bucket --------- Co-authored-by: Varadarajan V <[email protected]> Co-authored-by: Varadarajan V <[email protected]> * bump walkme integration version to 1.2.0 (#768) * fixes typo and related test (#771) * fixes typo and related test some test were returning false positive, update the way to check on them * bump package version to 1.2.1 --------- Co-authored-by: Varadarajan V <[email protected]> * Support for SystemJS in MadKudu integration (#765) * UMD need window.require * Update version * msg id and version updated * fixed walkme test case file * msg id added in productPropertyMap * removed msgId from propertyMap --------- Co-authored-by: paco-walkme <[email protected]> Co-authored-by: Varadarajan V <[email protected]> Co-authored-by: Varadarajan V <[email protected]> Co-authored-by: Ghassen Rjab <[email protected]>
AnkitSegment
added a commit
that referenced
this pull request
Aug 7, 2023
* [Walkme] Add option to choose a custom bucket (#759) * Add option to choose a custom bucket --------- Co-authored-by: Varadarajan V <[email protected]> Co-authored-by: Varadarajan V <[email protected]> * bump walkme integration version to 1.2.0 (#768) * fixes typo and related test (#771) * fixes typo and related test some test were returning false positive, update the way to check on them * bump package version to 1.2.1 --------- Co-authored-by: Varadarajan V <[email protected]> * Support for SystemJS in MadKudu integration (#765) * UMD need window.require * Update version * msg id and version updated * fixed walkme test case file * msg id added in productPropertyMap * removed msgId from propertyMap * added logs in track and page events --------- Co-authored-by: paco-walkme <[email protected]> Co-authored-by: Varadarajan V <[email protected]> Co-authored-by: Varadarajan V <[email protected]> Co-authored-by: Ghassen Rjab <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds support for SystemJS in MadKudu integration.
When ran on a SystemJS environment
window.define.amdis defined but notwindow.require. Which prevented the MadKudu script from loading.Are there breaking changes in this PR?
No.
Testing
Testing not required because we just add a new check for
window.requirefor UMD. If not present, we will usethis.load.Any background context you want to provide?
The PR is crated based on this issue #761
Is there parity with the server-side/android/iOS integration components (if applicable)?
No.
Does this require a new integration setting? If so, please explain how the new setting works
No.
Links to helpful docs and other external resources