Create template for prom-alertmanager docker container #442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clintonsteiner
force-pushed
the
prom-alertmanager
branch
from
bef103f
to
a78aa6a
Compare
nwithan8
requested changes
Dec 20, 2023
clintonsteiner
added a commit
to clintonsteiner/unRAID-CA-templates
that referenced
this pull request
Dec 20, 2023
nwithan8
requested changes
Dec 20, 2023
|
@nwithan8 thanks for taking the time to review. Appreciate you helping me get this polished up before merging |
clintonsteiner
force-pushed
the
prom-alertmanager
branch
from
e3b5914
to
6a92120
Compare
|
@nwithan8 Looks like you need write access to merge pr's. Are you able to merge this or do we need to wait for another reviewer to come by? |
Roxedus
requested changes
Dec 22, 2023
* Was missing so ported a template from the official dockerfile and image * Tested locally but first time making a template, feedback is welcome. * This is the guide I followed. https://selfhosters.net/docker/templating/templating/ * remove templateUrl param and value specified with a default -- from pr from roxedus {reviewers:nwithan8, roxedus}
clintonsteiner
force-pushed
the
prom-alertmanager
branch
from
6a92120
to
bb0bf76
Compare
|
@Roxedus appreciate you taking the time to review. Apologies for taking some time getting back to this, was away over the holidays |
Roxedus
approved these changes
Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Application install for this was missing so went ahead and created it based off the official dockerfile and image.
Tested locally but first time creating a template so let me know if you see any issues.
This is the guide I followed.
https://selfhosters.net/docker/templating/templating/