Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update rand to 0.8 #311

Merged
merged 1 commit into from
Aug 23, 2023
Merged

Conversation

crepererum
Copy link
Contributor

No description provided.

@jdm
Copy link
Member

jdm commented May 23, 2023

@bors-servo r+

@bors-servo
Copy link
Contributor

📌 Commit edcda6a has been approved by jdm

@bors-servo
Copy link
Contributor

⌛ Testing commit edcda6a with merge 66267b9...

bors-servo added a commit that referenced this pull request May 23, 2023
@bors-servo
Copy link
Contributor

💔 Test failed - checks-github

@crepererum
Copy link
Contributor Author

Looks unrelated to me:

  • Windows fails due to some winapi issues, might be fixed by Port windows implementation from winapi to windows-rs #302.

  • MacOS seems like a serious issue:

    thread '<unnamed>' panicked at 'panic in a function that cannot unwind', library/core/src/panicking.rs:126:5
    thread '<unnamed>' panicked at 'misaligned pointer dereference: address must be a multiple of 0x8 but is 0x7f9da8d0101d', src/platform/macos/mod.rs:539:17
    

@mrobinson
Copy link
Member

Some months later, after some more changes and enabling the merge queue, things look fine now. I will land this.

@mrobinson mrobinson added this pull request to the merge queue Aug 23, 2023
Merged via the queue into servo:master with commit b9253db Aug 23, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants