Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add rustfmt and clippy into CI #323

Closed
wants to merge 1 commit into from
Closed

Add rustfmt and clippy into CI #323

wants to merge 1 commit into from

Conversation

ikrivosheev
Copy link
Contributor

Closes: #222

  • added rustfmt and clippy into CI
  • fixed clippy warnings
  • replaced actions-rs/toolchain to dtolnay/rust-toolchain

mrobinson
mrobinson requested changes Aug 29, 2023
View reviewed changes
Copy link
Member

@mrobinson mrobinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this change! In order to verify the clippy fixes, would you be willing to split this PR into two? The first could do a rustfmt and then the second could fix the clippy issues. That would make this a bit easier to review. Thanks!

.github/workflows/main.yml
Comment on lines +26 to +27
- name: rustfmt
run: cargo fmt --features "${{ matrix.features }}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably run in check mode in order to fail on the CI if the input isn't formatted?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mrobinson hello! thank you for the review, yes, i can.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First PR: #324. After merge it I will create new PR with clippy.

@ikrivosheev ikrivosheev deleted the feature/rustfmt_clippy branch August 29, 2023 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrobinson mrobinson mrobinson requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Set up rustfmt
2 participants
@ikrivosheev @mrobinson