Upgrade to mio 0.8
#326
Merged
Upgrade to mio 0.8
#326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change upgrades `mio` for non-MacOS / non-Android unix platforms. `mio` is used an abstraction layer over the various methods of doing `epoll`, etc on Unix platforms. There are a few notable changes this upgrade deals with: - `mio` no longer supports level-triggered events. What this means is that instead of always delivering readable events for file descriptors when there is data left to read, an event is only delivered the first time new data becomes available. The consumer is expected to try to read from descriptor until it would block. This means we have to put a loop around calls to recv for each file descriptor. Note that this might change the order that messages arrive, since before each polling operation would only give one message per fd. Now all available messages are delivered per call to poll. - The `mio` API has changed a bit. Now there's a poll registry and also `Ready` has been replaced by `Interest`.
jdm
approved these changes
Sep 10, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change upgrades
miofor non-MacOS / non-Android unix platforms.miois used an abstraction layer over the various methods of doingepoll, etc on Unix platforms.There are a few notable changes this upgrade deals with:
miono longer supports level-triggered events. What this means isthat instead of always delivering readable events for file
descriptors when there is data left to read, an event is only
delivered the first time new data becomes available. The consumer is
expected to try to read from descriptor until it would block. This
means we have to put a loop around calls to recv for each file
descriptor. Note that this might change the order that messages
arrive, since before each polling operation would only give one
message per fd. Now all available messages are delivered per call to
poll.
mioAPI has changed a bit. Now there's a poll registry and alsoReadyhas been replaced byInterest.