[pull] master from 2i2c-org:master #524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
Make all GCP clusters support the instance types 4, 16, and 64 CPU highmem nodes
Co-authored-by: Yuvi Panda <[email protected]>
Stop using continuous prePuller
- Switch to using modify_pod_hook to setup additional volumeMounts, as it is a list and not a dictionary (and hence gets replaced, not merged) - Even with that, there's a discrepancy between setting up the shared-readwrite by default at /home/jovyan/shared-readwrite vs for rstudio users it needing to be in /home/rstudio/shared-readwrite. This is solved by just mounting /home/rstudio and /homve/jovyan (along with appropriate shared and shared-readwrite) for *all* users. This allows rocker images (which use the rstudio user and put home ine /home/rstudio) to be first class citizens along with jupyter based images, regardless of how they are specified ( via the configurator, or with unlisted_choice, or as a profile). For non-rocker images, this is just invisible in the UI and there is no performance overhead for these extra bind mounts. An additional positive here is that in case *students* end up accidentally hardcoding paths in their notebooks, it will continue to work regardless of wether they or on RStudio or JupyterLab (described to us as a serious problem by openscapes) Ref https://2i2c.freshdesk.com/a/tickets/1083
Handled by extraVolumeMounts in basehub instead
Make sure rstudio admins also get shared-readwrite mounted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )