Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Initial progress on the Shackle runtime implementation #106

Open
wants to merge 12 commits into
base: develop
Choose a base branch
from

Conversation

Dekker1
Copy link
Contributor

@Dekker1 Dekker1 commented Dec 14, 2023

This PR is very much a work in process, made available here to track the testing of the branch to ensure I keep the level of testing up-to-scratch.

Must haves:

  • Parameter value representation
    • Integers (includes Boolean) |boxed + unboxed|
    • Floats |boxed + unboxed|
    • Strings |boxed|
    • Sequences (e.g., tuples and array) |boxed|
    • Int/Float sets |boxed|
    • Sequence Views (e.g., slices, indexed, or transposed sequences) |boxed|
  • Decision variable representation
    • Boolean
    • Integer
    • Float
    • Set of Integers
  • Initial interpreter functionality
  • Propagator design

Maybe part of this, or in future PRs

  • Optimize data parsers to directly produce runtime values
  • Solver interfacing

Copy link

codecov bot commented Dec 14, 2023

Codecov Report

Attention: Patch coverage is 86.03604% with 248 lines in your changes missing coverage. Please review.

Project coverage is 72.16%. Comparing base (f0604a8) to head (4207266).

Files Patch % Lines
crates/shackle-runtime/src/value/set.rs 87.29% 77 Missing ⚠️
crates/shackle-runtime/src/value.rs 83.27% 46 Missing ⚠️
crates/shackle-runtime/src/value/seq.rs 89.37% 41 Missing ⚠️
crates/shackle-runtime/src/value/int_set_var.rs 0.00% 16 Missing ⚠️
crates/shackle-runtime/src/value/bool_var.rs 0.00% 15 Missing ⚠️
crates/shackle-runtime/src/value/float_var.rs 0.00% 15 Missing ⚠️
crates/shackle-runtime/src/value/int_var.rs 0.00% 15 Missing ⚠️
crates/shackle-runtime/src/value/num.rs 97.24% 12 Missing ⚠️
crates/shackle-runtime/src/builtin.rs 0.00% 9 Missing ⚠️
crates/shackle-runtime/src/error.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #106      +/-   ##
===========================================
+ Coverage    71.13%   72.16%   +1.02%     
===========================================
  Files          126      137      +11     
  Lines        24061    25837    +1776     
===========================================
+ Hits         17116    18644    +1528     
- Misses        6945     7193     +248     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Dekker1 Dekker1 force-pushed the feature/runtime branch 7 times, most recently from 14922eb to d30a2c3 Compare December 19, 2023 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant