support (non-standard) sm4-gcm, sm4-ccm in v1-aead-extra #60
Annotations
27 warnings
large size difference between variants:
src/v2/udp/mod.rs#L14
warning: large size difference between variants
--> src/v2/udp/mod.rs:14:1
|
14 | / enum CipherVariant {
15 | | AesGcm(AesGcmCipher),
| | -------------------- the largest variant contains at least 560 bytes
16 | | ChaCha20Poly1305(ChaCha20Poly1305Cipher),
| | ---------------------------------------- the second-largest variant contains at least 32 bytes
17 | | #[cfg(feature = "v2-extra")]
18 | | ChaCha8Poly1305(ChaCha8Poly1305Cipher),
19 | | }
| |_^ the entire enum is at least 560 bytes
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant
= note: `#[warn(clippy::large_enum_variant)]` on by default
help: consider boxing the large fields to reduce the total size of the enum
|
15 | AesGcm(Box<AesGcmCipher>),
| ~~~~~~~~~~~~~~~~~
|
the borrowed expression implements the required traits:
src/v1/cipher.rs#L45
warning: the borrowed expression implements the required traits
--> src/v1/cipher.rs:45:22
|
45 | m.update(&digest);
| ^^^^^^^ help: change this to: `digest`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
= note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default
|
use Vec::sort_by_key here instead:
src/v1/streamcipher/table.rs#L31
warning: use Vec::sort_by_key here instead
--> src/v1/streamcipher/table.rs:31:13
|
31 | table.sort_by(|x, y| (a % (*x + i)).cmp(&(a % (*y + i))))
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `table.sort_by_key(|x| a % (*x + i))`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by
= note: `#[warn(clippy::unnecessary_sort_by)]` on by default
|
the loop variable `counter` is only used to index `data`:
src/v1/streamcipher/crypto/rc4.rs#L66
warning: the loop variable `counter` is only used to index `data`
--> src/v1/streamcipher/crypto/rc4.rs:66:24
|
66 | for counter in 0..data.len() {
| ^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
= note: `#[warn(clippy::needless_range_loop)]` on by default
help: consider using an iterator
|
66 | for <item> in &mut data {
| ~~~~~~ ~~~~~~~~~
|
casting to the same type is unnecessary (`usize` -> `usize`):
src/v1/streamcipher/crypto/rc4.rs#L53
warning: casting to the same type is unnecessary (`usize` -> `usize`)
--> src/v1/streamcipher/crypto/rc4.rs:53:24
|
53 | state.swap(counter as usize, index2 as usize);
| ^^^^^^^^^^^^^^^^ help: try: `counter`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
= note: `#[warn(clippy::unnecessary_cast)]` on by default
|
constants have by default a `'static` lifetime:
src/v1/cipher.rs#L113
warning: constants have by default a `'static` lifetime
--> src/v1/cipher.rs:113:37
|
113 | const SUBKEY_INFO: &'static [u8] = b"ss-subkey";
| -^^^^^^^----- help: consider removing `'static`: `&[u8]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes
= note: `#[warn(clippy::redundant_static_lifetimes)]` on by default
|
buid-test-check (ubuntu-latest)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions/cache@v2, actions-rs/toolchain@v1, actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
buid-test-check (ubuntu-latest)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
buid-test-check (ubuntu-latest)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
buid-test-check (ubuntu-latest)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
buid-test-check (ubuntu-latest)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
large size difference between variants:
src/v2/udp/mod.rs#L14
warning: large size difference between variants
--> src/v2/udp/mod.rs:14:1
|
14 | / enum CipherVariant {
15 | | AesGcm(AesGcmCipher),
| | -------------------- the largest variant contains at least 560 bytes
16 | | ChaCha20Poly1305(ChaCha20Poly1305Cipher),
| | ---------------------------------------- the second-largest variant contains at least 32 bytes
17 | | #[cfg(feature = "v2-extra")]
18 | | ChaCha8Poly1305(ChaCha8Poly1305Cipher),
19 | | }
| |_^ the entire enum is at least 560 bytes
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant
= note: `#[warn(clippy::large_enum_variant)]` on by default
help: consider boxing the large fields to reduce the total size of the enum
|
15 | AesGcm(Box<AesGcmCipher>),
| ~~~~~~~~~~~~~~~~~
|
the borrowed expression implements the required traits:
src/v1/cipher.rs#L45
warning: the borrowed expression implements the required traits
--> src/v1/cipher.rs:45:22
|
45 | m.update(&digest);
| ^^^^^^^ help: change this to: `digest`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
= note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default
|
use Vec::sort_by_key here instead:
src/v1/streamcipher/table.rs#L31
warning: use Vec::sort_by_key here instead
--> src/v1/streamcipher/table.rs:31:13
|
31 | table.sort_by(|x, y| (a % (*x + i)).cmp(&(a % (*y + i))))
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `table.sort_by_key(|x| a % (*x + i))`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by
= note: `#[warn(clippy::unnecessary_sort_by)]` on by default
|
the loop variable `counter` is only used to index `data`:
src/v1/streamcipher/crypto/rc4.rs#L66
warning: the loop variable `counter` is only used to index `data`
--> src/v1/streamcipher/crypto/rc4.rs:66:24
|
66 | for counter in 0..data.len() {
| ^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
= note: `#[warn(clippy::needless_range_loop)]` on by default
help: consider using an iterator
|
66 | for <item> in &mut data {
| ~~~~~~ ~~~~~~~~~
|
casting to the same type is unnecessary (`usize` -> `usize`):
src/v1/streamcipher/crypto/rc4.rs#L53
warning: casting to the same type is unnecessary (`usize` -> `usize`)
--> src/v1/streamcipher/crypto/rc4.rs:53:24
|
53 | state.swap(counter as usize, index2 as usize);
| ^^^^^^^^^^^^^^^^ help: try: `counter`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
= note: `#[warn(clippy::unnecessary_cast)]` on by default
|
constants have by default a `'static` lifetime:
src/v1/cipher.rs#L113
warning: constants have by default a `'static` lifetime
--> src/v1/cipher.rs:113:37
|
113 | const SUBKEY_INFO: &'static [u8] = b"ss-subkey";
| -^^^^^^^----- help: consider removing `'static`: `&[u8]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes
= note: `#[warn(clippy::redundant_static_lifetimes)]` on by default
|
buid-test-check (macos-latest)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions/cache@v2, actions-rs/toolchain@v1, actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
buid-test-check (macos-latest)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
buid-test-check (macos-latest)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
buid-test-check (macos-latest)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
buid-test-check (macos-latest)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
buid-test-check (windows-latest)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions/cache@v2, actions-rs/toolchain@v1, actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
buid-test-check (windows-latest)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
buid-test-check (windows-latest)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
buid-test-check (windows-latest)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
buid-test-check (windows-latest)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|