-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shm 3831 #9
base: dev
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I opened the PR but the code was written by others
|
||
try { | ||
data = await axios.get(url, {timeout: 2000}); | ||
data = await axios.get(url, { timeout: 2000 }) |
Check warning
Code scanning / CodeQL
File data in outbound network request Medium
file data
Outbound network request depends on
file data
.get(archiverUrl, {timeout: 2000}) | ||
.then(res => res.data) | ||
.catch(err => console.error(err)); | ||
.get(archiverUrl, { timeout: 2000 }) |
Check warning
Code scanning / CodeQL
File data in outbound network request Medium
file data
const url = `http://localhost:${config.server.ip.externalPort}/load`; | ||
const nodeLoad = await axios.get(url); | ||
const url = `http://localhost:${config.server.ip.externalPort}/load` | ||
const nodeLoad = await axios.get(url) |
Check warning
Code scanning / CodeQL
File data in outbound network request Medium
file data
const url = `http://localhost:${config.server.ip.externalPort}/tx-stats`; | ||
const txStats = await axios.get(url); | ||
const url = `http://localhost:${config.server.ip.externalPort}/tx-stats` | ||
const txStats = await axios.get(url) |
Check warning
Code scanning / CodeQL
File data in outbound network request Medium
file data
// const url = `http://localhost:${config.server.ip.externalPort}/nodeinfo`; | ||
const response = await axios.get(url, {timeout: 2000}); | ||
return response.data.nodeInfo; | ||
const response = await axios.get(url, { timeout: 2000 }) |
Check warning
Code scanning / CodeQL
File data in outbound network request Medium
file data
path.join(__dirname, `../../${File.ACTIVE_NODE}`), | ||
JSON.stringify(savedActiveNode) | ||
); | ||
fs.writeFileSync(path.join(__dirname, `../../${File.ACTIVE_NODE}`), JSON.stringify(savedActiveNode)) |
Check warning
Code scanning / CodeQL
Network data written to file Medium
Untrusted data
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to go
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to go but if this one is merged and if the current GUI use the merge version, there will be errors.
So, I think it is better to hold or the GUI users can't update their cli into latest version from the github.
No description provided.