Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shm 3831 #9

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

Shm 3831 #9

wants to merge 3 commits into from

Conversation

mssabr01
Copy link
Contributor

No description provided.

Copy link

linear bot commented May 24, 2024

Copy link
Contributor Author

@mssabr01 mssabr01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I opened the PR but the code was written by others

src/gui-commands.ts Dismissed Show dismissed Hide dismissed

try {
data = await axios.get(url, {timeout: 2000});
data = await axios.get(url, { timeout: 2000 })

Check warning

Code scanning / CodeQL

File data in outbound network request Medium

Outbound network request depends on
file data
.
Outbound network request depends on
file data
.
.get(archiverUrl, {timeout: 2000})
.then(res => res.data)
.catch(err => console.error(err));
.get(archiverUrl, { timeout: 2000 })

Check warning

Code scanning / CodeQL

File data in outbound network request Medium

Outbound network request depends on
file data
.
const url = `http://localhost:${config.server.ip.externalPort}/load`;
const nodeLoad = await axios.get(url);
const url = `http://localhost:${config.server.ip.externalPort}/load`
const nodeLoad = await axios.get(url)

Check warning

Code scanning / CodeQL

File data in outbound network request Medium

Outbound network request depends on
file data
.
const url = `http://localhost:${config.server.ip.externalPort}/tx-stats`;
const txStats = await axios.get(url);
const url = `http://localhost:${config.server.ip.externalPort}/tx-stats`
const txStats = await axios.get(url)

Check warning

Code scanning / CodeQL

File data in outbound network request Medium

Outbound network request depends on
file data
.
// const url = `http://localhost:${config.server.ip.externalPort}/nodeinfo`;
const response = await axios.get(url, {timeout: 2000});
return response.data.nodeInfo;
const response = await axios.get(url, { timeout: 2000 })

Check warning

Code scanning / CodeQL

File data in outbound network request Medium

Outbound network request depends on
file data
.
path.join(__dirname, `../../${File.ACTIVE_NODE}`),
JSON.stringify(savedActiveNode)
);
fs.writeFileSync(path.join(__dirname, `../../${File.ACTIVE_NODE}`), JSON.stringify(savedActiveNode))

Check warning

Code scanning / CodeQL

Network data written to file Medium

Write to file system depends on
Untrusted data
.
Copy link
Contributor

@mgthuramoemyint mgthuramoemyint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go

Copy link
Contributor

@mgthuramoemyint mgthuramoemyint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go but if this one is merged and if the current GUI use the merge version, there will be errors.
So, I think it is better to hold or the GUI users can't update their cli into latest version from the github.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants