This repository has been archived by the owner on Mar 30, 2019. It is now read-only.
Implementing vertical field of view #1117
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This would be a breaking change to the existing API. You should probably create a version with this parameter, and redirect the previous implementation to this new one using a default parameter for this new parameter |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The vertical aspect ratio should be extendable by aspect ratio if below the conditional width ratio (for instance: the calculation of the vertical height scale is divided with 4:3 by 16:9 and the horizontal width is locked to 16:9) so I wanted to make the parameter part of the perspective field of view matrix.