Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Menubar window resize fix #457

Merged
merged 2 commits into from
Jan 5, 2020
Merged

Conversation

tuttza
Copy link
Contributor

@tuttza tuttza commented Jan 5, 2020

I think I found the issue(and a fix!) that was causing windows not to be able to shrink after making the window larger with Menus enabled.

The culprit resides in gtk.c essentially we were incorrectly referencing the widget pointer.

before:

    GtkWidget *wdg = app->slot->oscanvas;
    gtk_widget_set_size_request(wdg, app->width, app->height);

after:

    GtkWidget *wdg = app->slot->oscanvas;
    gtk_widget_set_size_request(&wdg, app->width, app->height);

Also I added some braces around if statements (which is really most of the other changes). I think we should start doing that seems to be a good practice follow.

@ccoupe ccoupe merged commit 971cf67 into shoes:master Jan 5, 2020
@ccoupe
Copy link

ccoupe commented Jan 5, 2020

Sadly there are problems.

  1. The scrollbar resizing is incorrect - try the manual with menus enabled to see it. There is a history of these two bugs in an xor relationship.
  2. I get a long line(s?) of garbage on my linux launch terminal when Shoes exits.

Reference #430

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants