Make AVCaptureSession calls thread safe #1526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shogo4405
requested changes
Aug 2, 2024
There was a problem hiding this comment.
In the design of HK, the role of lockQueue is assigned to IOStream.lockQueue.
In the PR, both IOStream.lockQueue and IOCaptureSession have lockQueue, causing a redundancy in roles, which is unacceptable.
If you stop placing lockQueue in IOCaptureSession and instead use IOStream's lockQueue, it will be acceptable.
levs42
force-pushed
the
bugfix/media-services-reset
branch
from
7c20bf9
to
cfa815a
Compare
levs42
force-pushed
the
bugfix/media-services-reset
branch
from
cfa815a
to
fa3259a
Compare
|
Updated, please take a look |
TestCase 1
It works a camera and a microphone. Case 2 |
|
Awesome, thank you for sharing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & motivation
This PR is a fix for #1522 to make AVCaptureSession
startRunningandbeginConfigurationcalls thread safe.Type of change