-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow unsetting target technology #115
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your PR!
I have no idea what target technology does ( 😊 ), but I tried this PR and can confirm this change allows to unset it.
Hi @exyi! Thank you for the contribution! |
Target technology sets the objective for the CostAnalysis solver in terms of the required number of science packs. Setting it to null means to aim for all finite technologies
Sure! The setting sets the resource objectives for the linear programming solver. Most importantly, YAFC then shows the estimated required resource amounts to something I'll actually need soon-ish, rather than in 1000 hours 😅. But it also affects the costs slightly, |
Could you please describe the behavior before and after the change? |
You have to save project and restart YAFC (or also change mining productivity...). That's another glitch that YAFC doesn't update the cost analysis when preferences change, only when settings change (same thing as Dorus encountered with the pollution cost flag Dorus#1). Now, the option is to also enable change event for preferences (see the linked commit), or move this into settings. Do you know the difference between the two? |
AFAIK, target technology option could not be set to null from GUI - to all researches.