Refactor crate::format #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Directly expose `format::{Input, Output}` instead
|
It's weird that this is failing only on ffmpeg 7 for Mac. |
|
It looks like the same thing is happening on master, so it's not a result of this PR. I'll go ahead and review. Thanks. |
shssoichiro
approved these changes
Oct 15, 2024
It's the same as in #72, homebrew only offers "5", "6" and "7" with no more granularity. "7" recently updated to 7.1 which currently fails to build.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the
Formatenum which wraps aroundformat::Inputandformat::Output.I am not sure why this wrapper existed in the first place.. I can't think of a good reason to use it. Separating the Input/Output API makes more sense IMO.
A bit of functionality got lost via the
openfunctions, but this can be added back (thinking of a builder pattern atm)