New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't pass `AsRef<T>` params by reference #84

Merged

shssoichiro merged 2 commits into shssoichiro:master from FreezyLemon:fix-asref-params

Nov 5, 2024

Contributor

FreezyLemon commented Nov 4, 2024

Doesn't really make sense to require a reference for these params, as both String and &str (etc.) implement AsRef<Path>.

This is breaking.

FreezyLemon added 2 commits

November 4, 2024 21:24


          Pass T: AsRef<U> directly, without reference

99fb132


          Fix examples

61adbb8

shssoichiro approved these changes

View reviewed changes

shssoichiro merged commit 979e287 into shssoichiro:master

20 checks passed

FreezyLemon deleted the fix-asref-params branch

November 5, 2024 08:20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet