Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix beacon_chain metrics descriptions #6576

Open
wants to merge 3 commits into
base: unstable
Choose a base branch
from

Conversation

rista404
Copy link

@rista404 rista404 commented Nov 7, 2024

Issue Addressed

n/a

Proposed Changes

Just fixed a small mistake in the metrics description.

Additional Info

n/a

@CLAassistant
Copy link

CLAassistant commented Nov 7, 2024

CLA assistant check
All committers have signed the CLA.

@rista404 rista404 changed the title Fix typo in beacon_chain metrics Fix beacon_chain metrics descriptions Nov 8, 2024
Copy link
Member

@jxs jxs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@michaelsproul michaelsproul changed the base branch from stable to unstable November 14, 2024 02:12
@michaelsproul
Copy link
Member

sorry @rista404, can you rebase on unstable and push a new commit?

Github won't recognise the change of base branch until a new commit is pushed

@rista404
Copy link
Author

@michaelsproul rebased!

@michaelsproul
Copy link
Member

Thanks!

Just a couple of formatting issues that you can fix with cargo fmt --all and then we're good to go

(see CI failure: https://github.com/sigp/lighthouse/actions/runs/11834376784/job/32976250705?pr=6576)

@rista404
Copy link
Author

Weird, my editor was supposed to do that.

Done 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants