Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write range sync tests in external event-driven form #6618

Open
wants to merge 3 commits into
base: unstable
Choose a base branch
from

Conversation

dapplion
Copy link
Collaborator

@dapplion dapplion commented Nov 27, 2024

Issue Addressed

Re-write existing range sync tests into an event-driven format to accommodate the refactor introduced in

This format was introduced in

and does not make assumptions about internal functions, it treats sync as a black box inputting actual events used in production.

Note: I've removed the generics used in range sync since now we don't unit test directly

@dapplion dapplion added work-in-progress PR is a work-in-progress syncing labels Nov 27, 2024
@dapplion dapplion marked this pull request as ready for review November 27, 2024 13:53
@dapplion dapplion added ready-for-review The code is ready for review and removed work-in-progress PR is a work-in-progress labels Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-review The code is ready for review syncing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant