Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct flakey CI tests #6646

Open
wants to merge 2 commits into
base: unstable
Choose a base branch
from
Open

Correct flakey CI tests #6646

wants to merge 2 commits into from
+3 −2

Conversation

AgeManning
Copy link
Member

Issue Addressed

Some subnet service tests were failing occasionally. There were two bugs that I found.

I've run these tests repeatedly without fail, so at the very least, should make these more stable.

@AgeManning AgeManning added the ready-for-review The code is ready for review label Dec 2, 2024
@michaelsproul
Copy link
Member

Clippy is failing

@ackintosh ackintosh mentioned this pull request Dec 2, 2024
Open
@michaelsproul
Copy link
Member

Does the test_subscribe_same_subnet_several_slots_apart test need the same fix as the same_slot test? It is still failing on this branch: https://github.com/sigp/lighthouse/actions/runs/12114467475/job/33771078350?pr=6646

@michaelsproul michaelsproul added test improvement Improve tests waiting-on-author The reviewer has suggested changes and awaits thier implementation. v6.1.0 New release c. Q1 2025 and removed ready-for-review The code is ready for review labels Dec 2, 2024
@michaelsproul michaelsproul mentioned this pull request Dec 2, 2024
Open
@syjn99 syjn99 mentioned this pull request Dec 3, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
test improvement Improve tests v6.1.0 New release c. Q1 2025 waiting-on-author The reviewer has suggested changes and awaits thier implementation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AgeManning @michaelsproul