-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sign releases with ambient credentials via Github Actions #60
Conversation
Signed-off-by: Alex Cameron <[email protected]>
Signed-off-by: Alex Cameron <[email protected]>
I'm testing this via another branch. I'll add a job to sign the LICENSE file and see if that works ok. |
Signed-off-by: Alex Cameron <[email protected]>
8473895
to
dc0c231
Compare
Signed-off-by: Alex Cameron <[email protected]>
If you're interested in seeing this in action, head over to #61 and have a look at the "sign" check I added. It essentially just runs: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with just one small nit!
Co-authored-by: Dustin Ingram <[email protected]>
Signed-off-by: William Woodruff <[email protected]>
* Support conformance testing on third-party PRs Signed-off-by: Alex Cameron <[email protected]> * README: Provide guidance on how to safely run conformance testing in pull requests Signed-off-by: Alex Cameron <[email protected]> * README: formatting Signed-off-by: William Woodruff <[email protected]> Signed-off-by: Alex Cameron <[email protected]> Signed-off-by: William Woodruff <[email protected]> Co-authored-by: William Woodruff <[email protected]>
Summary
This change hooks up the ambient credential detection to the CLI and uses it to sign releases in Github Actions.
Ticket Link
See #31. Does not close, since other detectors are needed.