Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added IncludeSourceRevisionInInformationalVersion to SampleApp so Version doesn't get added garbage #117

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

tombogle
Copy link
Contributor

@tombogle tombogle commented Apr 11, 2024

Added some test code to the sample app to try to re-create and diagnose problem the Bloom team encountered.


This change is Reviewable

… so that Version doesn't get added garbage

Added some test code to the sample app to try to re-create and diagnose problem the Bloom team encountered.
@tombogle tombogle requested a review from andrew-polk April 11, 2024 19:02
@tombogle tombogle self-assigned this Apr 11, 2024
Copy link

github-actions bot commented Apr 11, 2024

Test Results

    3 files  ±0    84 suites  ±0   16s ⏱️ -1s
165 tests ±0  160 ✔️ ±0    5 💤 ±0  0 ±0 
495 runs  ±0  480 ✔️ ±0  15 💤 ±0  0 ±0 

Results for commit e326dee. ± Comparison against base commit f0bbbd9.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@andrew-polk andrew-polk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is obsolete with #120

Reviewed 1 of 2 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: 1 of 2 files reviewed, all discussions resolved (waiting on @tombogle)

…rict (default) and permissive initialization mode
@tombogle
Copy link
Contributor Author

tombogle commented Nov 4, 2024

I guess that is mostly true. But since we do have the StrictInitializationMode property, I've made it so the SampleApp can properly test the behavior when that is set to false and also (bit more subtly) demonstrate the expected behavior when true.

Copy link
Contributor

@andrew-polk andrew-polk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @tombogle)

Copy link
Contributor

@andrew-polk andrew-polk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this worth a commitlog entry?

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @tombogle)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants