-
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added IncludeSourceRevisionInInformationalVersion to SampleApp so Version doesn't get added garbage #117
base: master
Are you sure you want to change the base?
Conversation
… so that Version doesn't get added garbage Added some test code to the sample app to try to re-create and diagnose problem the Bloom team encountered.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is obsolete with #120
Reviewed 1 of 2 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: 1 of 2 files reviewed, all discussions resolved (waiting on @tombogle)
…rict (default) and permissive initialization mode
I guess that is mostly true. But since we do have the StrictInitializationMode property, I've made it so the SampleApp can properly test the behavior when that is set to false and also (bit more subtly) demonstrate the expected behavior when true. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @tombogle)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this worth a commitlog entry?
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @tombogle)
Added some test code to the sample app to try to re-create and diagnose problem the Bloom team encountered.
This change is