Fix qdmlsl instructions #1195
Open
Fix qdmlsl instructions #1195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like the high_n unit tests are incorrect, looking into it |
The qdmlsl instructions were implemented without any saturation. This has been fixed by utilising existing saturating instructions which are implemented correctly. Unit tests have also been updated to test for saturation. Change-Id: Ia9e5a7bd850bc178920c19e390c17db5a3bfbc4f
The qdmlsl instructions were implemented without any saturation. This has been fixed by utilising existing saturating instructions which are implemented correctly. Unit tests have also been updated to test for saturation.
Thanks. I'm still seeing some test failures:
There is a compile failure with MSVC, maybe that will be helpful: https://ci.appveyor.com/project/nemequ/simde/builds/50436859/job/4lpievni4ibfsa7h#L2440 (our entire MSVC CI matrix failed, not just that version: https://ci.appveyor.com/project/nemequ/simde/builds/50436859) |
|
Ping @Ryo-not-rio ; any update on this or your other PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The qdmlsl instructions were implemented without any saturation. This has been fixed by utilising existing saturating instructions which are implemented correctly.
Unit tests have also been updated to test for saturation.