Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Whoops, missing comma #1233

Merged
merged 1 commit into from
Nov 23, 2024
Merged

Conversation

Dave-Lowndes
Copy link

No description provided.

@mr-c
Copy link
Collaborator

mr-c commented Nov 19, 2024

Thank you @Dave-Lowndes ; do you have a test case to trigger this bug?

@Dave-Lowndes
Copy link
Author

@mr-c No test case I'm afraid, it just showed up when doing code analysis of Surge XT code with PVS-Studio.

@Dave-Lowndes
Copy link
Author

@mr-c Do I need to do anything further to get this completed?

@mr-c
Copy link
Collaborator

mr-c commented Nov 21, 2024

@Dave-Lowndes If you could report the llvm fatal backend error (which is not related to this PR, but does block me from merging all SIMDe PRs), that would be really helpful: https://github.com/simd-everywhere/simde/actions/runs/11917581735/job/33213028281?pr=1233#step:8:1067

Then to work around it, we'll have to find a version of emscripten using an llvm build from before that error was introduced and update

./emsdk install tot
./emsdk activate tot
from tot to that emscripten version number

@Dave-Lowndes
Copy link
Author

I've created an issue: llvm/llvm-project#117200
but I've no familiarity with such things so you might want to add anything you're aware of as a comment there.

@mr-c mr-c enabled auto-merge (rebase) November 22, 2024 23:04
@mr-c mr-c merged commit 73e43dd into simd-everywhere:master Nov 23, 2024
96 of 97 checks passed
@Dave-Lowndes Dave-Lowndes deleted the CommaMissing branch November 23, 2024 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants