Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Look for a default config file in $HOME/.svglintrc.js #90

Merged
merged 10 commits into from
Oct 31, 2023

Conversation

kcaran
Copy link
Contributor

@kcaran kcaran commented Sep 6, 2023

This application was exactly what I was look for. Thank you!

I'd like to have a global default config file that I can keep with my environment files: $HOME/.svglintrc.js. This pull looks in your home directory for a .svglintrc.js file if there are no other candidates (i.e. in the working directory or any of its parents). To help me I added the name of the configuration file used to the debug output, and incorporated it in the configuration file tests.

@ericcornelissen

This comment was marked as outdated.

Copy link
Contributor

@ericcornelissen ericcornelissen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Despite the number of comments I think the implementation is pretty much good-to-go.

One further ask: can you update the "Config" section of the docs to include this lookup.

src/cli/config.js Outdated Show resolved Hide resolved
src/cli/config.js Outdated Show resolved Hide resolved
src/cli/config.js Outdated Show resolved Hide resolved
test/cli.spec.js Outdated Show resolved Hide resolved
test/cli.spec.js Outdated Show resolved Hide resolved
test/svgs/attr.test.svg Outdated Show resolved Hide resolved
@kcaran

This comment was marked as outdated.

README.md Outdated Show resolved Hide resolved
src/cli/config.js Show resolved Hide resolved
@ericcornelissen ericcornelissen merged commit f15e463 into simple-icons:master Oct 31, 2023
14 checks passed
Copy link

🎉 This PR is included in version 2.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants