Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve types for Config #93

Merged
merged 2 commits into from
Mar 15, 2024

Conversation

mondeja
Copy link
Member

@mondeja mondeja commented Mar 14, 2024

Not exhaustive but definitely much better than the current typing.

So you can use:

/** @type {import('svglint').Config} */
export default {
  rules: {
    ...

@ericcornelissen
Copy link
Contributor

@mondeja
Copy link
Member Author

mondeja commented Mar 15, 2024

Done. Seems that the type of Cheerio is unresolved in the whole codebase.

@ericcornelissen ericcornelissen merged commit 0445664 into simple-icons:master Mar 15, 2024
14 checks passed
Copy link

🎉 This PR is included in version 2.7.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@mondeja mondeja deleted the better-config-types branch March 15, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants