Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add XO linter #98

Merged
merged 1 commit into from
Apr 26, 2024
Merged

chore: add XO linter #98

merged 1 commit into from
Apr 26, 2024

Conversation

LitoMore
Copy link
Member

No description provided.

@LitoMore LitoMore requested a review from mondeja April 15, 2024 23:59
@LitoMore LitoMore marked this pull request as draft April 15, 2024 23:59
@LitoMore LitoMore marked this pull request as ready for review April 16, 2024 00:10
Copy link
Member

@mondeja mondeja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed down to file src/rules/custom.js.

.github/workflows/test.yml Show resolved Hide resolved
bin/cli.js Outdated Show resolved Hide resolved
src/cli/components/linting.js Show resolved Hide resolved
src/cli/components/linting.js Show resolved Hide resolved
src/cli/components/linting.js Outdated Show resolved Hide resolved
src/lib/linting.js Outdated Show resolved Hide resolved
src/lib/linting.js Show resolved Hide resolved
src/lib/parse.js Outdated Show resolved Hide resolved
src/lib/parse.js Outdated Show resolved Hide resolved
src/lib/rule-loader.js Outdated Show resolved Hide resolved
src/lib/linting.js Show resolved Hide resolved
src/lib/rule-loader.js Outdated Show resolved Hide resolved
@mondeja mondeja linked an issue Apr 17, 2024 that may be closed by this pull request
test/api.spec.js Outdated Show resolved Hide resolved
src/lib/linting.js Outdated Show resolved Hide resolved
@mondeja mondeja changed the title Add XO linter chore: add XO linter Apr 17, 2024
@mondeja
Copy link
Member

mondeja commented Apr 17, 2024

Note that we need to use commit prefixes to automatically add changes to changelog. In this case I've changed the PR title to prefix it with chore: .

See https://github.com/semantic-release/semantic-release and https://github.com/semantic-release/commit-analyzer

@LitoMore LitoMore force-pushed the xo branch 6 times, most recently from 163fa8e to cd6693f Compare April 25, 2024 17:01
@mondeja
Copy link
Member

mondeja commented Apr 25, 2024

See the hidden conversations.

@LitoMore LitoMore force-pushed the xo branch 6 times, most recently from 94f28ac to 4b2454e Compare April 26, 2024 07:44
Copy link
Member

@mondeja mondeja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼 Feel free to merge it.

@LitoMore LitoMore merged commit d6f1444 into master Apr 26, 2024
16 checks passed
@LitoMore LitoMore deleted the xo branch April 26, 2024 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use the node: protocol when importing builtin modules
2 participants